Remove output stream logic. #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvertdw
commented
Apr 7, 2025
| recorder.setCloseOutputStream(true); | ||
| try | ||
| { | ||
| recorder.flush(); |
Member
Author
There was a problem hiding this comment.
stop already calls flush
calvertdw
commented
Apr 7, 2025
| public boolean isCloseOutputStream() | ||
| { | ||
| return recorder.isCloseOutputStream(); | ||
| } |
Member
Author
There was a problem hiding this comment.
close output stream is only for when you pass one in. we're passing in a file. it's always gonna be false
calvertdw
commented
Apr 7, 2025
|
|
||
| long startTime = System.currentTimeMillis(); | ||
| Frame capturedFrame; | ||
| while (!magewellMuxer.isCloseOutputStream() && ((capturedFrame = grabber.grabAtFrameRate()) != null)) |
Member
Author
There was a problem hiding this comment.
Wait, so were we actually using the closeOutputStream variable to signal that we wanted to stop the recording?? 😂
Member
Author
There was a problem hiding this comment.
I've added back the closed logic, but not using an unrelated internal variable
ds58
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.